Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relative path in unix socket URLs #153

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Allow relative path in unix socket URLs #153

merged 2 commits into from
Dec 16, 2024

Conversation

aiven-sal
Copy link
Member

Close #123

@aiven-sal aiven-sal added the bug Something isn't working label Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.22%. Comparing base (02c2bfe) to head (e9e3bfb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   76.22%   76.22%           
=======================================
  Files         130      130           
  Lines       33940    33946    +6     
=======================================
+ Hits        25871    25877    +6     
  Misses       8069     8069           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mkmkme
mkmkme previously approved these changes Dec 13, 2024
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiven-sal aiven-sal enabled auto-merge December 13, 2024 16:57
@aiven-sal aiven-sal disabled auto-merge December 13, 2024 16:57
Close #123

Signed-off-by: Salvatore Mesoraca <[email protected]>
@aiven-sal aiven-sal merged commit 1d0ac55 into main Dec 16, 2024
93 checks passed
@aiven-sal aiven-sal deleted the aiven-sal/url branch December 16, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unix socket can't connect to .sock file in the current directory by relatice path
3 participants